After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728597 - Search providers being duplicated. including empty results.
Search providers being duplicated. including empty results.
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: search
3.12.x
Other Linux
: Normal major
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-20 09:56 UTC by Michael Heyns
Modified: 2014-04-30 21:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screencast of duplicating search results. (1.35 MB, video/webm)
2014-04-20 10:09 UTC, Michael Heyns
  Details
search: Make sure to destroy old provider displays when we unregister (1.08 KB, patch)
2014-04-22 03:36 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Michael Heyns 2014-04-20 09:56:27 UTC
Searching lists duplicate items, many of them empty. Can be worked around by disabling search, restarting shell, enabling search, restarting shell. Enabling or disabling a search provider will multiply the amount of results. I have managed to crash the shell just by switching a provider on and off multiple times.

Please have a look at the attached screencast for an accurate demonstration.
Comment 1 Michael Heyns 2014-04-20 10:09:39 UTC
Created attachment 274751 [details]
Screencast of duplicating search results.
Comment 2 Michael Catanzaro 2014-04-22 03:04:59 UTC
Confirming, bug can be reproduced by turning off a search provider
Comment 3 Jasper St. Pierre (not reading bugmail) 2014-04-22 03:36:42 UTC
Created attachment 274858 [details] [review]
search: Make sure to destroy old provider displays when we unregister

When we unregistered providers, like when we refreshed the list of
active remote providers, we would forget to destroy the old provider
display after the fact. This left an empty "skeleton" provider display
still in the search results that would never be filled in. Make sure
to destroy it properly.
Comment 4 Jasper St. Pierre (not reading bugmail) 2014-04-22 03:37:12 UTC
Attachment 274858 [details] pushed as a83b9ed - search: Make sure to destroy old provider displays when we unregister
Comment 5 Michael Catanzaro 2014-04-30 21:49:35 UTC
Hey Jasper, I think this fix should go into gnome-3-12 as well.