GNOME Bugzilla – Bug 728578
Update UI of starter plugin
Last modified: 2014-06-14 06:47:17 UTC
Created attachment 274745 [details] [review] Patch to update UI of starter plugin There are some design suggestions regarding how a hypothetical "Gnome IDE" would look on this page: https://wiki.gnome.org/Design/Apps/IDE. I attempted to rework the existing starter plugin to resemble an IDE design here: https://raw.github.com/gnome-design-team/gnome-mockups/master/ide/png/launch-screen.png I didn't copy the design because I think it's worth pointing out on the starter page how to access Anjuta help, how to access GTK Documentation, and where to go to search for arbitrary examples of how to use the API in actual applications.
This patch also addresses bug 681430
Thank for your patch. I'm not a specialist of the design. The new pane looks fine for me but I think it would be better if the right pane is wider and re sizable. I have some pretty long path names and the current pane is too small. Is there some other people having an opinion about this redesign? By the way, could you use git format-patch to generate your patch, it will be a bit easier to apply.
Created attachment 275015 [details] [review] Patch to update UI of starter plugin Created using git format-patch master --stdout > modern_start.patch
Thank you for your feedback. The listbox displaying the recent projects is now resizable horizontally. Very long paths will also wrap around if there's not enough space.
Review of attachment 275015 [details] [review]: Thank for your work. The new start page is fine for me. Then could you merge all the patches in only one unless it's related to a different feature. But in this last case, it's better to open several bug reports. Then, could avoid changing indentation and whitespace in block you haven't modified, else it's difficult to know which lines to check. If you want to fix indentation, I think it's better to do all these changes in a single commit without any other changes.
Created attachment 275232 [details] [review] Condensed updated starter patch I think this is what you were asking for. The new patch condenses all changes to a single commit. It also does not include the formatting changes I mistakenly included in the previous patch; the plugin should be formatted with tabs, not spaces.
Review of attachment 275232 [details] [review]: Thank, yes it's better like this. You could have split in two patches: one just fixing the indentation and adding a priv argument to the plugin but that's fine like this. There is only last change needed, you need Gtk 3.10 so you must update the minimum version requirement in the configure.ac file. Then, I prefer to keep minimal version requirements to make easy to recompile Anjuta from sources without needing to upgrade your whole system or use jhbuild. Gtk 3.10 is available now in most distribution except Mint that should be release shortly. I plan to wait for it to commit this patch. Is it fine for you?
Created attachment 275279 [details] [review] Patch including updated starter plugin and updated configure.ac Waiting is perfectly acceptable. Attached is the patch, now including the updated configure.ac.
Review of attachment 275279 [details] [review]: Thank for your update. I have committed your patch, the file org.gnome.anjuta.starter.gschema.xml.in was missing in the latest version, I have added it.