After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728474 - bind new GtkListBox selection API
bind new GtkListBox selection API
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings: GTK+ GStreamer WebKitGTK+
unspecified
Other All
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-17 23:35 UTC by Allison Karlitskaya (desrt)
Modified: 2014-04-18 01:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gtk+-3.0: fix flowbox selection foreach API (1.94 KB, patch)
2014-04-17 23:35 UTC, Allison Karlitskaya (desrt)
committed Details | Review
gtk+-3.0: add new GtkListBox selection API (16.36 KB, patch)
2014-04-17 23:35 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2014-04-17 23:35:49 UTC
See patches.
Comment 1 Allison Karlitskaya (desrt) 2014-04-17 23:35:51 UTC
Created attachment 274635 [details] [review]
gtk+-3.0: fix flowbox selection foreach API

The callback doesn't have a destroy notify, so don't mark it 'owned'.
Additionally, it's not OK to pass a NULL callback to a foreach function.
Comment 2 Allison Karlitskaya (desrt) 2014-04-17 23:35:54 UTC
Created attachment 274636 [details] [review]
gtk+-3.0: add new GtkListBox selection API

metadata copied from the similar api on GtkFlowBox (which is where the
GtkListBox API itself was modelled from).
Comment 3 Luca Bruno 2014-04-17 23:38:40 UTC
Review of attachment 274635 [details] [review]:

Thanks.
Comment 4 Luca Bruno 2014-04-17 23:39:05 UTC
Review of attachment 274636 [details] [review]:

Thanks.
Comment 5 Allison Karlitskaya (desrt) 2014-04-18 01:48:32 UTC
Thanks for the quick reviews.