After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728409 - correcly test paramspec's value type in gimarshallingtests
correcly test paramspec's value type in gimarshallingtests
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-04-17 09:25 UTC by Matijs van Zuijlen
Modified: 2015-02-07 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Correctly retrieve param's value_type (841 bytes, patch)
2014-04-17 09:25 UTC, Matijs van Zuijlen
committed Details | Review

Description Matijs van Zuijlen 2014-04-17 09:25:54 UTC
Created attachment 274584 [details] [review]
Correctly retrieve param's value_type

gi_marshalling_tests_param_spec_in_bool is supposed to check that its argument specifies a parameter of type boolean. However, it erroneously compares the param spec's type ("GParamBoolean") instead of its value type ("GBoolean"). The attached patch fixes this.
Comment 1 Emmanuele Bassi (:ebassi) 2014-04-17 09:38:33 UTC
Review of attachment 274584 [details] [review]:

obviously correct.
Comment 2 Matijs van Zuijlen 2014-05-30 17:16:30 UTC
What can I do to get this merged?
Comment 3 André Klapper 2015-02-07 16:52:48 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]