After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728407 - Enabling selection mode via right-click doesn't work inside albums in Albums view
Enabling selection mode via right-click doesn't work inside albums in Albums ...
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.12.x
Other Linux
: Normal normal
: 3.14
Assigned To: gnome-music-maint
gnome-music-maint
available
Depends on:
Blocks:
 
 
Reported: 2014-04-17 07:59 UTC by Arnel Borja
Modified: 2014-05-19 09:26 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12

Attachments
Toggle selection mode on right click in album widget. (1.47 KB, patch)
2014-05-11 09:25 UTC, Sai Suman Prayaga 		reviewed Details | Review
Attachment for the patch (2.35 KB, patch)
2014-05-18 19:48 UTC, Sai Suman Prayaga 		none Details | Review

Description Arnel Borja 2014-04-17 07:59:58 UTC 
1. Open Albums view
2. Select an album
3. Right-click on a song in the right

Expected: Selection mode would be enabled, item will be selected
Comment 1 Allan Day 2014-04-22 15:07:26 UTC 
Yep, I agree.
Comment 2 Sai Suman Prayaga 2014-05-11 09:25:02 UTC 
Created attachment 276322 [details] [review]
Toggle selection mode on right click in album widget.
Comment 3 Vadim Rutkovsky 2014-05-12 11:29:52 UTC 
Review of attachment 276322 [details] [review]:

Didn't work for me on latest master, could you check if any of recent change has broken it?
Comment 4 Arnel Borja 2014-05-12 14:08:15 UTC 
Sorry, I actually fixed it in Advanced Search branch last week and it just got merged today, so it's now fixed.

https://git.gnome.org/browse/gnome-music/commit/?id=3eb1df9d9737986b323d68c5c985dcca30e9e4d4
Comment 5 Arnel Borja 2014-05-12 14:22:04 UTC 
Somehow it no longer works XD
Comment 6 Sai Suman Prayaga 2014-05-18 19:48:53 UTC 
Created attachment 276734 [details] [review]
Attachment for the patch

The changes are made to the albumwidget directly instead of connecting the albumwidget view to 'selection-mode-request' in the albums and search classes.
Comment 7 Vadim Rutkovsky 2014-05-19 09:26:28 UTC 
Thanks, pushed as https://git.gnome.org/browse/gnome-music/commit/?id=3d86e3f to master
Also pushed https://git.gnome.org/browse/gnome-music/commit/?id=118f270 to gnome-3-12, will be a part of 3.12.3 release