After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728390 - Use headerbar in the preferences dialog
Use headerbar in the preferences dialog
Status: RESOLVED FIXED
Product: swell-foop
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: swell-foop-maint
swell-foop-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-17 03:11 UTC by Robert Roth
Modified: 2014-04-18 02:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (2.45 KB, patch)
2014-04-17 03:11 UTC, Robert Roth 		needs-work Details | Review
Proposed patch (3.22 KB, patch)
2014-04-18 00:15 UTC, Robert Roth 		committed Details | Review

Description Robert Roth 2014-04-17 03:11:19 UTC 
Created attachment 274555 [details] [review]
Proposed patch

Based on the HIG [1], the preferences dialog should use a headerbar with a single close button instead of the close button from the action area.

The attached patch solves that.

[1]
Comment 1 Robert Roth 2014-04-17 03:11:58 UTC 
Somehow the HIG link didn't make it, so here it is:
https://wiki.gnome.org/Design/HIG/Dialogs#Presentation_Dialogs
Comment 2 Michael Catanzaro 2014-04-17 14:37:55 UTC 
Review of attachment 274555 [details] [review]:

Yes, but please:

* Update the <!-- interface-requires gtk+ 3.0 --> in preferences.ui, use-header-bar is new in 3.12
* Also bump the GTK+ dependency in configure.ac

Then this can be pushed.
Comment 3 Robert Roth 2014-04-18 00:15:09 UTC 
Created attachment 274637 [details] [review]
Proposed patch

Updated proposed patch, bumping the GTK requirement and adding the correct interface-requires version.
Comment 4 Michael Catanzaro 2014-04-18 02:56:50 UTC 
Thanks!