After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728370 - Some extractors are missing #ifdef HAVE_LIBMEDIAART
Some extractors are missing #ifdef HAVE_LIBMEDIAART
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: tracker-general
: 728494 730848 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-04-16 19:29 UTC by Xavier Claessens
Modified: 2014-07-07 10:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make sure vorbis extractor builds without libmediaart (1.87 KB, patch)
2014-04-16 19:29 UTC, Xavier Claessens
accepted-commit_now Details | Review

Description Xavier Claessens 2014-04-16 19:29:08 UTC
tracker master and 1.0 does not build with
  --disable-libmediaart
  --enable-libvorbis
Comment 1 Xavier Claessens 2014-04-16 19:29:39 UTC
Created attachment 274517 [details] [review]
Make sure vorbis extractor builds without libmediaart
Comment 2 Martyn Russell 2014-04-17 19:37:04 UTC
Comment on attachment 274517 [details] [review]
Make sure vorbis extractor builds without libmediaart

Nice catch! :)
Comment 3 Martyn Russell 2014-04-19 07:32:37 UTC
*** Bug 728494 has been marked as a duplicate of this bug. ***
Comment 4 Xavier Claessens 2014-04-21 15:03:13 UTC
Pushed.
Comment 5 Martyn Russell 2014-05-28 08:30:54 UTC
*** Bug 730848 has been marked as a duplicate of this bug. ***
Comment 6 Martyn Russell 2014-06-05 08:56:38 UTC
Seems this is still occuring: https://bugs.gentoo.org/attachment.cgi?id=378042
Comment 7 Martyn Russell 2014-06-05 09:10:08 UTC
commit 3a360934d4520db279490e1c5c929aa61916ac90
Author: Martyn Russell <martyn@lanedo.com>
Date:   Thu Jun 5 10:08:30 2014 +0100

    tracker-extract: Fix build with libav when libmediaaart is disabled
    
    https://bugzilla.gnome.org/show_bug.cgi?id=728370

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

This should be available in 1.0.3
Comment 8 Pacho Ramos 2014-06-24 18:31:16 UTC
I cannot find it in tracker-1.0 branch... I guess master will be used for 1.0.3 then?
Comment 9 Martyn Russell 2014-07-07 10:36:41 UTC
(In reply to comment #8)
> I cannot find it in tracker-1.0 branch... I guess master will be used for 1.0.3
> then?

I will be doing a 1.1.0 release (unstable) during this week if I get the time.

I may be able to get a 1.0.3 release (stable) out too with this fix.