Created attachment 274468 [details] [review]
gaction: Minor clarifications in the GAction documentation

strings can only be NULL if that is explicitly mentioned. Adding these clarifications all over the place only muddies the picture.

Review of attachment 274468 [details] [review]:

I agree.

::: gio/gaction.c
@@ +87,3 @@
    *
    * The name of the action.  This is mostly meaningful for identifying
+   * the action once it has been added to a #GActionGroup. It is immutable and

Please remove the "must not be %NULL" here.

@@ +105,3 @@
    * The type of the parameter that must be given when activating the
+   * action. This is immutable, and may be %NULL if no parameter is needed when
+   * activating the action.

This is fine (and actually helpful).

@@ +139,3 @@
    *
    * The #GVariantType of the state that the action has, or %NULL if the
+   * action is stateless. This is immutable.

Also fine.

@@ +238,3 @@
  * Queries the name of @action.
  *
+ * Returns: the name of the action, which must not be %NULL

Please remove this one.

Created attachment 274941 [details] [review]
gaction: Minor clarifications in the GAction documentation

Review of attachment 274941 [details] [review]:

Looks good.  Thanks.

Thanks for the fast review. Merged to master.

Attachment 274941 [details] pushed as 99b6761 - gaction: Minor clarifications in the GAction documentation