After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728322 - omvideodec: don't unref caps before logging field from it
omvideodec: don't unref caps before logging field from it
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal minor
: 1.2.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-16 09:09 UTC by Aurélien Zanelli
Modified: 2014-07-23 08:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
omxvideodec: don't unref caps before logging field from it (967 bytes, patch)
2014-04-16 09:09 UTC, Aurélien Zanelli 		committed Details | Review

Description Aurélien Zanelli 2014-04-16 09:09:54 UTC 
Created attachment 274431 [details] [review]
omxvideodec: don't unref caps before logging field from it

In gst_omx_video_dec_negotiate() function, we log negotiating format extracted from caps. However, caps structure has been unref before. It causes logging to access memory it should not.

I attached a patch which fix it.
Comment 1 Sebastian Dröge (slomo) 2014-04-17 07:34:13 UTC 
commit da4cf3da1f15e06307c5bc6ff45a953b29e6e0ae
Author: Aurélien Zanelli <aurelien.zanelli@parrot.com>
Date:   Wed Apr 16 11:00:55 2014 +0200

    omxvideodec: don't unref caps before logging field from it
    
    https://bugzilla.gnome.org/show_bug.cgi?id=728322