After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728271 - telepathyClient: Only use 12-hour format when supported by the locale
telepathyClient: Only use 12-hour format when supported by the locale
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-15 15:26 UTC by Florian Müllner
Modified: 2014-05-28 20:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
telepathyClient: Only use 12-hour format when supported by the locale (7.77 KB, patch)
2014-04-15 15:26 UTC, Florian Müllner 		committed Details | Review
Reattached patch (1.91 KB, patch)
2014-04-15 15:38 UTC, Florian Müllner 		none Details | Review

Description Florian Müllner 2014-04-15 15:26:34 UTC 
See patch.
Comment 1 Florian Müllner 2014-04-15 15:26:37 UTC 
Created attachment 274375 [details] [review]
telepathyClient: Only use 12-hour format when supported by the locale

It is a bit odd to request AM/PM format when the locale selected
by LC_TIME lacks the concept. We ignore the format setting in that
case elsewhere and assume 24-hour format, let's do the same for
chat timestamps for consistency.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-04-15 15:27:46 UTC 
Review of attachment 274375 [details] [review]:

Is it possible to get a -w diff of the same patch?
Comment 3 Florian Müllner 2014-04-15 15:38:45 UTC 
Created attachment 274377 [details] [review]
Reattached patch

You could just git-bz apply, but sure ...
Comment 4 Florian Müllner 2014-05-28 20:05:22 UTC 
Attachment 274375 [details] pushed as b8f0d0f - telepathyClient: Only use 12-hour format when supported by the locale