After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728226 - Blending mode of layers in ORA changed upon opening
Blending mode of layers in ORA changed upon opening
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
git master
Other All
: Normal normal
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2014-04-14 22:55 UTC by Alexandre Prokoudine
Modified: 2014-06-16 11:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.16 KB, patch)
2014-05-09 16:40 UTC, Massimo
none Details | Review

Description Alexandre Prokoudine 2014-04-14 22:55:13 UTC
GIMP changed blending mode of some layers in ORA files when opening them. Thus saving back even without actually adjusting anything changes the visual representation of data.
Comment 1 Alexandre Prokoudine 2014-04-14 22:59:37 UTC
File in question: https://dl.dropboxusercontent.com/u/55576315/mage_girl.ora

It's >1.6MB large, attaching won't work :)
Comment 2 Daniel Sabo 2014-04-17 03:58:39 UTC
If the file is to large just attaching the stack.xml from before and after should be enough to see what's wrong, you can get it by doing:

unzip -x mage_girl.ora stack.xml
Comment 3 Massimo 2014-05-09 16:40:16 UTC
Created attachment 276253 [details] [review]
proposed patch

Judging from

> http://www.freedesktop.org/wiki/Specifications/OpenRaster/Draft/LayersStack/#composite-opattribute

and

> https://git.gnome.org/browse/gimp/tree/plug-ins/pygimp/plug-ins/file-openraster.py#n23

it seems that GIMP's plug-in is missing

svg:color
svg:luminosity
svg:hue
svg:saturation

and

svg:dst-in
svg:dst-out

The attached patch adds the first 4. I think that even if these GIMP
layer-modes are not working exactly as specified by SVG/ORA they
should be better than NORMAL_MODE
Comment 4 Michael Natterer 2014-05-09 20:37:19 UTC
That patch looks "obviously right" but then i have not the slightest
clue about ORA. I suggest you proceed at your own best judgement :)
Comment 5 Massimo 2014-05-10 16:56:40 UTC
Given that ORA is an open exchange format I consider the problem
fixed in master and gimp-2-8

commit 6f6a51274fb728256fec1ff786124276b8cca8c5
Author: Massimo Valentini <mvalentini@src.gnome.org>
Date:   Sat May 10 18:46:31 2014 +0200

    Bug 728226: Blending mode of layers in ORA changed upon opening
    
    (cherry picked from commit 07ff7c7d6db573e36db1b3c2ba03d89eb6b4f9e1)
Comment 6 sergey 2014-06-16 08:52:37 UTC
i'm download and substitute the file https://git.gnome.org/browse/gimp/plain/plug-ins/pygimp/plug-ins/file-openraster.py?h=gimp-2-8 in /usr/lib64/gimp/2.0/plug-ins/file-openraster.py but Blending mode of layers in ORA changed upon opening dont fix


original .ora  https://dl.dropboxusercontent.com/u/60483793/gimpora/001.ora



exported .ora https://dl.dropboxusercontent.com/u/60483793/gimpora/6g2.ora
Comment 7 Massimo 2014-06-16 11:55:57 UTC
(In reply to comment #6)
> i'm download and substitute the file
> https://git.gnome.org/browse/gimp/plain/plug-ins/pygimp/plug-ins/file-openraster.py?h=gimp-2-8
> in /usr/lib64/gimp/2.0/plug-ins/file-openraster.py but Blending mode of layers
> in ORA changed upon opening dont fix
> 
> 
> original .ora  https://dl.dropboxusercontent.com/u/60483793/gimpora/001.ora
> 
> 
> 
> exported .ora https://dl.dropboxusercontent.com/u/60483793/gimpora/6g2.ora

This one seems to be a file obtained exporting the original after
cropping it to a size of 531x1203 starting at 1467, 642.

All layer modes (composite-op in the included stack.xml) are, 
in both files, svg:src-over.

The first is probably saved from mypaint because it contains an attribute
mypaint_strokemap_v2 and the associated .dat file that GIMP does not load
and does not export. If this is what you consider a bug than it is 
unrelated to changing blending modes and probably you should open another
bug report