After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728140 - Illegal parameter passed to g_variant_new in gtk_application_impl_dbus_inhibit
Illegal parameter passed to g_variant_new in gtk_application_impl_dbus_inhibit
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkApplication
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
: 728413 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-04-14 00:20 UTC by Niclas Lockner
Modified: 2014-04-22 23:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gtkapplication: Fix incorrect value passed to g_variant_new() (1.24 KB, patch)
2014-04-14 14:41 UTC, Bastien Nocera
committed Details | Review

Description Niclas Lockner 2014-04-14 00:20:36 UTC
As of this commit:
https://git.gnome.org/browse/gtk+/commit/?id=1409d7c4bdc22238e19578b1f37dd312f4bcb9da 
0 is passed as the second parameter to g_variant_new if window is null, which causes the calling process to crash.

According to https://developer.gnome.org/glib/2.40/gvariant-format-strings.html, "@u" expects a non-null (GVariant *)
Comment 1 Bastien Nocera 2014-04-14 14:41:27 UTC
Created attachment 274276 [details] [review]
gtkapplication: Fix incorrect value passed to g_variant_new()

The code expected to format @u, not u.
Comment 2 Bastien Nocera 2014-04-14 18:28:28 UTC
Attachment 274276 [details] pushed as 80993ea - gtkapplication: Fix incorrect value passed to g_variant_new()
Comment 3 Matthias Clasen 2014-04-22 23:43:30 UTC
*** Bug 728413 has been marked as a duplicate of this bug. ***