Comment on attachment 274215 [details]
Language File for Apache Thrift IDL

Thanks, the file looks good (couple of minor nitpicks inline below)

If you also add it to Makefile.am and POTFILE.in and submit it as a "git format-patch" it would be very appreciated and the commit would be properly credit to you


><language id="thrift" _name="Thrift" version="2.0" _section="Sources">
>  <metadata>
>    <property name="mimetypes">text/x-thrift</property>

I do not think this mime type is included in shared-mime-info, so for the time being I would omit it (this metadata is not mandatory)


>    <context id="block-comment" style-ref="comment" class="comment" class-disabled="no-spell-check">
>      <start>/\*</start>
>      <end>\*/</end>
>      <include>
>        <context ref="def:escape"/>
>        <context ref="def:line-continue"/>

Is including escape and line-continue inside comment sections intentional or just copying from other lang files? If they are not needed you can simply use def:c-like-comment etc. If they are needed, then ok as you did.

>    </context>

purely stylistic: leave an empty line between each context definition

>    <context id="line-comment" style-ref="comment" end-at-line-end="true" class="comment" class-disabled="no-spell-check">

Hey Paolo,

Thanks for the review, I'll make the suggested updates and submit a patch.

Best,
Randy

Note: if you don't know how to use git, the .lang file is better than nothing.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.