After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728066 - Deal with startup notify id being NULL
Deal with startup notify id being NULL
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-04-11 22:51 UTC by Matthias Clasen
Modified: 2014-04-13 12:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Deal with startup notify id being NULL (2.29 KB, patch)
2014-04-11 22:51 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2014-04-11 22:51:08 UTC 
The app launch context may just not support startup notification,
in which case, g_app_launch_context_get_startup_notify_id() will
return NULL.

Failure to take this into account leads to criticals like this:
gnome-session[8489]: GLib-CRITICAL: g_variant_new_take_string: assertion 'string != NULL' failed
gnome-session[8489]: GLib-CRITICAL: g_variant_new_variant: assertion 'value != NULL' failed
gnome-session[8489]: GLib-CRITICAL: g_variant_get_type: assertion 'value != NULL' failed
gnome-session[8489]: GLib-CRITICAL: g_variant_type_is_subtype_of: assertion 'g_variant_type_check (type)' failed
Comment 1 Matthias Clasen 2014-04-11 22:51:12 UTC 
Created attachment 274141 [details] [review]
Deal with startup notify id being NULL
Comment 2 Colin Walters 2014-04-11 23:00:56 UTC 
Review of attachment 274141 [details] [review]:

Looks good.
Comment 3 Matthias Clasen 2014-04-12 02:01:22 UTC 
Attachment 274141 [details] pushed as 94e5daf - Deal with startup notify id being NULL
Comment 4 Allison Karlitskaya (desrt) 2014-04-13 12:50:05 UTC 
Thanks!