GNOME Bugzilla – Bug 728039
Maintain user location's selection
Last modified: 2014-04-11 14:58:49 UTC
See patches.
Created attachment 274095 [details] [review] userLocation: Getter/setter for selection
Created attachment 274096 [details] [review] mapView: Maintain user location's selection If user location is selected, currently that selection is lost on updates. Lets maintain the selection un updates.
Review of attachment 274095 [details] [review]: Looks fine apart from nit below. ::: src/userLocation.js @@ +118,3 @@ + getSelected: function() { + return this._locationMarker && this._locationMarker.get_selected (); We don't do the space before parenthesis thing in gjs.
Review of attachment 274096 [details] [review]: Looks good, apart from some style issues. If the below is fixed then this can go as well. ::: src/mapView.js @@ +167,3 @@ this.geoclue.location); + var selected = (this._userLocation)? this._userLocation.getSelected() : false; We use let everywhere else so I think we should stick to that unless there is some special need to use var here? Also, this could maybe be written as: let selected = this._userLocation && this._userLocation.getSelected(); ?
Attachment 274095 [details] pushed as f30b71f - userLocation: Getter/setter for selection Attachment 274096 [details] pushed as 8738c9f - mapView: Maintain user location's selection