After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728023 - Warning when passing NULL window to inhibit
Warning when passing NULL window to inhibit
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkApplication
3.12.x
Other Mac OS
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-04-11 08:47 UTC by Bastien Nocera
Modified: 2014-04-12 01:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkapplication: Fix passing NULL as the window to inhibit (1.30 KB, patch)
2014-04-11 08:54 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2014-04-11 08:47:41 UTC 
This happens in totem-plugin-viewer which doesn't have a toplevel window to pass to gtk_application_inhibit()

+ Trace 233459

  • #0 g_logv
    at gmessages.c line 1038
  • #1 g_log
    at gmessages.c line 1071
  • #2 g_return_if_fail_warning
  • #3 gtk_widget_get_window
    at gtkwidget.c line 15124
  • #4 gtk_application_impl_x11_get_window_system_id
    at gtkapplication-x11.c line 68
  • #5 gtk_application_impl_dbus_get_window_system_id
    at gtkapplication-dbus.c line 321
  • #6 gtk_application_impl_dbus_inhibit
    at gtkapplication-dbus.c line 338
  • #7 totem_embedded_set_state
    at totem-plugin-viewer.c line 327
  • #8 totem_embedded_set_state
    at totem-plugin-viewer.c line 457
  • #9 totem_embedded_play
    at totem-plugin-viewer.c line 449
  • #10 totem_embedded_open_internal
    at totem-plugin-viewer.c line 417
  • #11 totem_embedded_open_uri
    at totem-plugin-viewer.c line 805
  • #12 handle_method_call
    at totem-plugin-viewer.c line 2055
  • #13 call_in_idle_cb
    at gdbusconnection.c line 4884
  • #14 g_main_dispatch
    at gmain.c line 3067
  • #15 g_main_context_dispatch
    at gmain.c line 3677
  • #16 g_main_context_iterate
    at gmain.c line 3748
  • #17 g_main_loop_run
    at gmain.c line 3942
  • #18 gtk_main
    at gtkmain.c line 1192
  • #19 main
    at totem-plugin-viewer.c line 2387 






Comment 1


Bastien Nocera





          2014-04-11 08:54:49 UTC
        



Created attachment 274068 [details] [review]
gtkapplication: Fix passing NULL as the window to inhibit

gtk_application_inhibit() supports passing NULL, so don't
blindly pass the NULL window to
gtk_application_impl_dbus_get_window_system_id().






Comment 2


Matthias Clasen





          2014-04-12 01:53:00 UTC
        



Attachment 274068 [details] pushed as 1409d7c - gtkapplication: Fix passing NULL as the window to inhibit