After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728020 - backend: Use new "audio-filter" property
backend: Use new "audio-filter" property
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-04-11 08:26 UTC by Bastien Nocera
Modified: 2014-05-15 16:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gst: Add new flags for playbin (979 bytes, patch)
2014-04-11 08:26 UTC, Bastien Nocera 		committed Details | Review
backend: Use new "audio-filter" property (2.40 KB, patch)
2014-04-11 08:26 UTC, Bastien Nocera 		reviewed Details | Review
backend: Use new "audio-filter" property (3.73 KB, patch)
2014-05-15 15:05 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2014-04-11 08:26:19 UTC 
Untested
Comment 1 Bastien Nocera 2014-04-11 08:26:28 UTC 
Created attachment 274065 [details] [review]
gst: Add new flags for playbin

See https://bugzilla.gnome.org/show_bug.cgi?id=679031
Comment 2 Bastien Nocera 2014-04-11 08:26:33 UTC 
Created attachment 274066 [details] [review]
backend: Use new "audio-filter" property

So that the audio-filter can be bypassed if it's not going to
make any changes.
Comment 3 Philip Withnall 2014-04-15 16:32:40 UTC 
Review of attachment 274066 [details] [review]:

::: src/backend/bacon-video-widget.c
@@ -6433,3 @@
   gst_element_link_many (bvw->priv->audio_capsfilter,
-			 bvw->priv->audio_pitchcontrol,
-			 audio_converter,

Can’t you now eliminate the audio_converter construction code at the top of the function?
Comment 4 Philip Withnall 2014-04-15 16:33:40 UTC 
Review of attachment 274065 [details] [review]:

Looks good to me.
Comment 5 Bastien Nocera 2014-05-15 15:05:27 UTC 
Created attachment 276607 [details] [review]
backend: Use new "audio-filter" property

So that the audio-filter can be bypassed if it's not going to
make any changes.
Comment 6 Bastien Nocera 2014-05-15 16:10:26 UTC 
commit 7763f75e05901e739bfbce81b7b07182f88b560c
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri Apr 11 09:40:16 2014 +0200

    backend: Use new "audio-filter" property
    
    So that the audio-filter can be bypassed if it's not going to
    make any changes.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=728020

commit 22480af9819b207f03a0e405927024b4e6d16344
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri Apr 11 09:29:15 2014 +0200

    gst: Add new flags for playbin
    
    See https://bugzilla.gnome.org/show_bug.cgi?id=679031
    
    https://bugzilla.gnome.org/show_bug.cgi?id=728020