After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728011 - [regression] Python3 port breaks URI handling for thumbnails when opening a .xges file with missing clips
[regression] Python3 port breaks URI handling for thumbnails when opening a ....
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: General
Git
Other Linux
: Normal major
: 0.94
Assigned To: Lubosz Sarnecki
Pitivi maintainers
Depends on:
Blocks: 729527
 
 
Reported: 2014-04-11 02:25 UTC by Jean-François Fortin Tam
Modified: 2014-05-04 17:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix pep8 check (4.89 KB, patch)
2014-04-13 13:05 UTC, Lubosz Sarnecki 		none Details | Review
fix python3 md5 encoding exception (1016 bytes, patch)
2014-04-13 13:06 UTC, Lubosz Sarnecki 		none Details | Review

Description Jean-François Fortin Tam 2014-04-11 02:25:51 UTC 
This is what I get when trying to open a xges file where clips have moved around:

Traceback (most recent call last):

+ Trace 233457

  • File "./pitivi/project.py", line 537 in _missingURICb 
    return self.emit("missing-uri", project, error, asset)
  • File "./pitivi/utils/signal.py", line 213 in emit 
    *args, **kwargs)
  • File "./pitivi/utils/signal.py", line 188 in emit 
    res = cb(*ar, **kw)
  • File "./pitivi/mainwindow.py", line 874 in _projectManagerMissingUriCb 
    thumbnail_hash = md5(uri).hexdigest()
TypeError: Unicode-objects must be encoded before hashing 
 
** (pitivi:19567): WARNING **: Unhandled type tag GType
Comment 1 Lubosz Sarnecki 2014-04-11 18:40:35 UTC 
This one is pretty easy. I missed a encoding issue, since I didn't test this.
I have only run the regular test suite. Are there more issues left in the dogtail tests maybe?

These 2 commits fix this (the first one is just for making the pep8 check valid)

https://github.com/lubosz/pitivi/commits/md5fix
Comment 2 Thibault Saunier 2014-04-13 11:53:06 UTC 
Just attach those patches here?
Comment 3 Lubosz Sarnecki 2014-04-13 13:05:55 UTC 
Created attachment 274200 [details] [review]
fix pep8 check
Comment 4 Lubosz Sarnecki 2014-04-13 13:06:30 UTC 
Created attachment 274201 [details] [review]
fix python3 md5 encoding exception
Comment 5 Thibault Saunier 2014-04-13 14:34:50 UTC 
commit aea80145baa9cb63e0016e3b363c8cad530ad8f9
Author: Lubosz Sarnecki <lubosz@gmail.com>
Date:   Fri Apr 11 20:32:47 2014 +0200

    python3: fix encoding for md5
    
    https://bugzilla.gnome.org/show_bug.cgi?id=728011

commit 51e1799ab918506f4f0f09fa94fef4f9ab7dae8c
Author: Lubosz Sarnecki <lubosz@gmail.com>
Date:   Fri Apr 11 20:32:39 2014 +0200

    fix pep8 check
    
    https://bugzilla.gnome.org/show_bug.cgi?id=728011