After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728008 - Keyboard navigation should accept Enter as a key for clearing blocks
Keyboard navigation should accept Enter as a key for clearing blocks
Status: RESOLVED FIXED
Product: swell-foop
Classification: Applications
Component: general
3.12.x
Other Linux
: Normal major
: ---
Assigned To: swell-foop-maint
swell-foop-maint
available
Depends on:
Blocks:
 
 
Reported: 2014-04-11 00:58 UTC by Michael Catanzaro
Modified: 2014-09-10 12:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Enter key working same as space key for clearing blocks. (861 bytes, patch)
2014-09-09 17:16 UTC, amisha
reviewed Details | Review
Enter key working same as space key for clearing blocks. (815 bytes, patch)
2014-09-10 09:08 UTC, amisha
committed Details | Review

Description Michael Catanzaro 2014-04-11 00:58:18 UTC
Although Swell Foop was clearly designed with keyboard navigation in mind, there seems to no longer be any way to clear a clump of blocks using just the keyboard: pressing Enter always selects the New Game button.
Comment 1 Mario Wenzel 2014-04-11 07:10:22 UTC
Using the cursor keys and space to clear, this works immediately for me. Even after using the mouse for menus and thinks, the cursor keys and space work fine.

Could you look at that one again and reconfirm?
Comment 2 Michael Catanzaro 2014-04-11 12:23:44 UTC
OK, so Space is the secret.

Let's make Enter work as well.
Comment 3 Mario Wenzel 2014-04-11 12:29:53 UTC
I've never seen a single-player keyboard-driven control scheme that used the cursor keys and enter.

But I guess having both is alright. Maybe we could add the wasd-keys for navigation as well.
Comment 4 amisha 2014-09-09 17:16:48 UTC
Created attachment 285757 [details] [review]
Enter key working same as space key for clearing blocks.
Comment 5 Michael Catanzaro 2014-09-10 00:17:27 UTC
Review of attachment 285757 [details] [review]:

Thanks Amisha!

::: src/swell-foop.vala
@@ +180,1 @@
                 return true; //handle this one to avoid activating the toolbar button

But now you no longer return here when space is pressed.

I think the right way to do this would be:

case Gdk.Key.space:
case Gdk.Key.Return:
   view.cursor_click ();
   return true; //handle this one to avoid activating the toolbar button
Comment 6 amisha 2014-09-10 09:08:13 UTC
Created attachment 285803 [details] [review]
Enter key working same as space key for clearing blocks.
Comment 7 Michael Catanzaro 2014-09-10 12:23:37 UTC
Thanks!