GNOME Bugzilla – Bug 728008
Keyboard navigation should accept Enter as a key for clearing blocks
Last modified: 2014-09-10 12:23:40 UTC
Although Swell Foop was clearly designed with keyboard navigation in mind, there seems to no longer be any way to clear a clump of blocks using just the keyboard: pressing Enter always selects the New Game button.
Using the cursor keys and space to clear, this works immediately for me. Even after using the mouse for menus and thinks, the cursor keys and space work fine. Could you look at that one again and reconfirm?
OK, so Space is the secret. Let's make Enter work as well.
I've never seen a single-player keyboard-driven control scheme that used the cursor keys and enter. But I guess having both is alright. Maybe we could add the wasd-keys for navigation as well.
Created attachment 285757 [details] [review] Enter key working same as space key for clearing blocks.
Review of attachment 285757 [details] [review]: Thanks Amisha! ::: src/swell-foop.vala @@ +180,1 @@ return true; //handle this one to avoid activating the toolbar button But now you no longer return here when space is pressed. I think the right way to do this would be: case Gdk.Key.space: case Gdk.Key.Return: view.cursor_click (); return true; //handle this one to avoid activating the toolbar button
Created attachment 285803 [details] [review] Enter key working same as space key for clearing blocks.
Thanks!