After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728000 - Avoid reshowing the installed update notification at each login
Avoid reshowing the installed update notification at each login
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-04-10 22:32 UTC by Kalev Lember
Modified: 2014-04-11 12:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
update monitor: Split out a function (1.55 KB, patch)
2014-04-10 22:32 UTC, Kalev Lember 		committed Details | Review
update monitor: Set install-timestamp in a single place (2.35 KB, patch)
2014-04-10 22:32 UTC, Kalev Lember 		committed Details | Review
update monitor: Only show installed update notification once (1.39 KB, patch)
2014-04-10 22:32 UTC, Kalev Lember 		committed Details | Review

Description Kalev Lember 2014-04-10 22:32:05 UTC 
16:55 < mclasen> hughsie, kalev: one thing I didn't sort out before the .92 gnome-software release
16:56 < mclasen> is who is responsible for clearing the update information in the non-error case
16:56 < mclasen> as things are right now, we never remove the file, and if you restart gnome-software, you keep getting notified about 'just installed' updates
Comment 1 Kalev Lember 2014-04-10 22:32:36 UTC 
Created attachment 274048 [details] [review]
update monitor: Split out a function
Comment 2 Kalev Lember 2014-04-10 22:32:39 UTC 
Created attachment 274049 [details] [review]
update monitor: Set install-timestamp in a single place

Instead of setting it both when triggering an offline update and after
the reboot, only do the latter. This makes sure we have one code path no
matter if it was gnome-software or gnome-shell triggering the update.
Comment 3 Kalev Lember 2014-04-10 22:32:41 UTC 
Created attachment 274050 [details] [review]
update monitor: Only show installed update notification once

We don't need to nag the user to review installed updates; if they
choose to dismiss the notification, respect that and avoid reshowing it
again at next login.
Comment 4 Kalev Lember 2014-04-11 12:35:36 UTC 
Attachment 274048 [details] pushed as 317be79 - update monitor: Split out a function
Attachment 274049 [details] pushed as 0278959 - update monitor: Set install-timestamp in a single place
Attachment 274050 [details] pushed as b4b01e8 - update monitor: Only show installed update notification once