After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727993 - meta_accelerator_parse(): handle keysyms without the XF86 prefix
meta_accelerator_parse(): handle keysyms without the XF86 prefix
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-10 19:06 UTC by Owen Taylor
Modified: 2014-06-27 14:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
meta_accelerator_parse(): handle keysyms without the XF86 prefix (1.61 KB, patch)
2014-04-10 19:06 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2014-04-10 19:06:05 UTC 
(I haven't compile tested this - don't have a jhbuild with the the new
reorganized branches at the moment - noticed this when looking at the code.)
Comment 1 Owen Taylor 2014-04-10 19:06:07 UTC 
Created attachment 274032 [details] [review]
meta_accelerator_parse(): handle keysyms without the XF86 prefix

The GDK and hence GNOME standard is that keys that begin with XF86 according to
libxkbcommon not prefixed with XF86, though gdk_keyval_from_name() strips XF86
if provided. If libxkbcommon doesn't recognize the accelerator name without
XF86, try again adding XF86 to the start.

This restores compatibility with gnome-settings-daemon, schemas, and existing
user configuration.
Comment 2 Florian Müllner 2014-04-10 19:55:06 UTC 
Review of attachment 274032 [details] [review]:

(In reply to comment #0)
> (I haven't compile tested this

Compiles fine and fixes the issue.
Comment 3 Owen Taylor 2014-06-27 14:39:39 UTC 
Attachment 274032 [details] pushed as 8d29d22 - meta_accelerator_parse(): handle keysyms without the XF86 prefix