After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727989 - Add installed tests
Add installed tests
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
3.12.x
Other Linux
: Normal enhancement
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-10 18:14 UTC by Vadim Rutkovsky
Modified: 2014-04-29 17:43 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12


Attachments
Initial tests (31.65 KB, patch)
2014-04-10 18:14 UTC, Vadim Rutkovsky
none Details | Review
Installed tests infrastructure bits (6.38 KB, patch)
2014-04-10 18:14 UTC, Vadim Rutkovsky
none Details | Review

Description Vadim Rutkovsky 2014-04-10 18:14:10 UTC
Created attachment 274025 [details] [review]
Initial tests

The following patches are adding a minimal set of tests for Eye of Gnome
via UI. These tests are verifying various actions in EOG using dogtail [1] / behave [2] /
installed tests [3] and shall be executed on gnome-continuous [4]

The tests are split into two parts:
 1) Scenarios in *.feature files using gherkin [5] language to describe steps
to be performed. This scenarios are also useful for manual testing
 2) Step definitions for dogtail in steps/*.py files. These are dogtail
instructions to operate on running program


How to run those tests:
 1) compile eog with --enable-installed-tests switch
 2) run 'gnome-desktop-testing-runner eog' to execute all tests or
'gnome-desktop-testing-runner eog/undo' for one test of
undo operation.

[1] http://fedorahosted.org/dogtail
[2] https://pypi.python.org/pypi/behave
[3] https://wiki.gnome.org/action/show/Initiatives/GnomeGoals/InstalledTests
[4] https://wiki.gnome.org/Projects/GnomeContinuous
[5] https://github.com/cucumber/cucumber/wiki/Gherkin
Comment 1 Vadim Rutkovsky 2014-04-10 18:14:37 UTC
Created attachment 274026 [details] [review]
Installed tests infrastructure bits
Comment 2 Felix Riemann 2014-04-26 17:11:38 UTC
Is there anything special needed besides dogtail?
So far the tests are failing for me. Some manage to open the file open dialog but the rest (e.g. eog/about) only show the program window. Log shows

"searching for descendent of [application | eog]: "Help" menu (attempt 3)"
Comment 3 Vadim Rutkovsky 2014-04-28 09:54:05 UTC
Tried on latest master today and they worked for me in jhbuild. Could you dump the full output of 'gnome-desktop-testing-runner eog' command?
Comment 4 Felix Riemann 2014-04-28 21:27:56 UTC
My fault, sorry! I thought the test finds the GUI items via an internal identifier, but it actually identifies them by their labels. Obviously, that doesn't work if I am running it with German language. Some adjustments were still necessary to work with latest GtkFileChooser which opens the location entry a bit differently.

Thanks, for starting this!

commit ed8e8838cd07fb0bb6d97b76e1e0cf093d4559dd
Author: Felix Riemann <>
Date:   Mon Apr 28 23:22:07 2014 +0200

    Update installed tests to work with latest GtkFileChooser
    
    The location entry is shown differently now and apparently there is
    also a slightly longer timeout needed until one can press Enter.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=727989

commit 847fc70b24fdd7c5f276f41f0f3db755918e2221
Author: Vadim Rutkovsky <>
Date:   Thu Apr 10 18:14:13 2014 +0200

    Install tests using --enable-installed-tests switch

commit 8dffb2f1c34c25ccfd48c2a45acd035e386e7ace
Author: Vadim Rutkovsky <>
Date:   Thu Apr 10 18:13:19 2014 +0200

    Add initial installed tests
---
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 5 Vadim Rutkovsky 2014-04-28 22:00:51 UTC
(In reply to comment #4)
> Obviously, that doesn't work if I am running it with German language.
FYI we're considering to make tests work in any languages (using po files for translation), but this feature is not ready yet, so all these tests are supposed to work on C and en_US locales only.

> Some adjustments were
> still necessary to work with latest GtkFileChooser which opens the location
> entry a bit differently.
I regularly check the status of test on gnome-continuous and prepare patches for newest changes there. Do you want me to commit the test updates myself or file bugs  and attach pacthes for review?
Comment 6 Felix Riemann 2014-04-29 17:43:51 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Some adjustments were
> > still necessary to work with latest GtkFileChooser which opens the location
> > entry a bit differently.
> I regularly check the status of test on gnome-continuous and prepare patches
> for newest changes there. Do you want me to commit the test updates myself or
> file bugs  and attach pacthes for review?

Since I don't know much about how Dogtail/pyatspi work it's likely going to be faster if you fix the tests directly. Thanks!