After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727974 - Fix up failure-to-see-expected-message logging
Fix up failure-to-see-expected-message logging
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-04-10 15:46 UTC by Dan Winship
Modified: 2014-07-09 15:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix up failure-to-see-expected-message logging (4.32 KB, patch)
2014-04-10 15:46 UTC, Dan Winship
committed Details | Review

Description Dan Winship 2014-04-10 15:46:30 UTC
When GLib had been told to expect message X, but then actually saw
message Y, it would log the "did not see expected message" error with
message Y's log level and domain, which makes no sense. Change it to
log with domain "GLib" and G_LOG_LEVEL_CRITICAL instead.

Also, include the expected domain in the error message, so that if
that's the reason why the expectation didn't match, you can tell that
from the error message.

Update glib/tests/testing.c for these changes; for all other test
programs in GLib and elsewhere, this change should not break any
existing tests, it should only improve the output on failure.
Comment 1 Dan Winship 2014-04-10 15:46:32 UTC
Created attachment 274005 [details] [review]
Fix up failure-to-see-expected-message logging
Comment 2 Dan Winship 2014-07-09 14:48:47 UTC
This one was annoying me again, so I pushed it.

Attachment 274005 [details] pushed as be0b921 - Fix up failure-to-see-expected-message logging
Comment 3 Colin Walters 2014-07-09 15:06:25 UTC
Makes sense to me FWIW.