GNOME Bugzilla – Bug 727973
W32: focused button is visibly smaller
Last modified: 2014-04-10 18:12:41 UTC
This is noticeable in glade project closing confirmation dialog and in other dialogs. The button that has keyboard focus is drawn smaller. This becomes obvious when the whole dialog loses focus (gets backdropped), which cases the button in question to be drawn without the "focused" style.
Created attachment 274002 [details] [review] W32: remove border on default buttons
Created attachment 274003 [details] How dialog buttons look without the patch. The "Cancel" button has focus. This is not obvious, since the whole window is backdropped, and "Cancel" is drawn just like all other buttons, except that it's smaller.
Created attachment 274004 [details] How dialog buttons look with the patch.
Actually, it's not that it's smaller, it's that other buttons are bigger. My understanding of this is that by default a "Can Default" button is drawn with a 1px border. When it's focused, it's drawn without that border, because default-marker is drawn outside of it, and it occupies that extra 1px. On W32 default-marker is drawn as part of the button background by the theme part, so there's no need to reserve extra space. By the way, this affects Raleigh (at least on my machine it does). Also, this bug missed the 3.12 branchoff. Can the fix be backported?
Review of attachment 274002 [details] [review]: Seems like a step in the right direction. And yes, please put this patch on the gnome-3-12 branch too
Attachment 274002 [details] pushed as 5c6e967 - W32: remove border on default buttons
Attachment 274002 [details] pushed into gtk-3-12 as e41999c - W32: remove border on default buttons