After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727970 - videorate: remove dead code
videorate: remove dead code
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-10 14:40 UTC by Vincent Penquerc'h
Modified: 2015-12-16 11:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove dead code (1.16 KB, patch)
2014-04-10 14:40 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2014-04-10 14:40:30 UTC 
Created attachment 273999 [details] [review]
remove dead code

I'm not sure this is the right fix: it might be that the loop that increments count should not be always called at least once. It makes sense to put a frame last where the end time is though. The original patch is from 2008, and adds the whole bit of code, so this isn't a later-change-breaks-something.
Comment 1 Luis de Bethencourt 2015-12-16 11:07:45 UTC 
Review of attachment 273999 [details] [review]:

commit 033ce9b20d8e156f83419ec0e5ce5ae95d32a55b
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Thu Apr 10 15:36:15 2014 +0100

    videorate: remove dead code

    Since the loops increasing count from 0 are always run at least
    once (if count < 1), count will always be at least one when
    compared to the drop/dup conditions.

    Coverity 1139674