After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727959 - New game screen - increase padding between buttons
New game screen - increase padding between buttons
Status: RESOLVED FIXED
Product: gnome-mines
Classification: Applications
Component: general
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-mines-maint
gnome-mines-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-10 12:35 UTC by Allan Day
Modified: 2014-04-17 04:40 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12


Attachments
Increase spacing between new game buttons (987 bytes, patch)
2014-04-14 18:09 UTC, Chris Johns (ter0)
committed Details | Review
screenshot and modified screenshot (269.78 KB, image/png)
2014-04-14 22:37 UTC, Allan Day
  Details
Reduce the space between the new game buttons (966 bytes, patch)
2014-04-15 00:44 UTC, Michael Catanzaro
none Details | Review

Description Allan Day 2014-04-10 12:35:21 UTC
Currently the buttons are so close that they almost touch. I'd add a decent amount of padding - around 18 or 24 pixels or so:

https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/games/mines/mines2-new.png

This will look much better, and help to avoid mistakes.
Comment 1 Chris Johns (ter0) 2014-04-14 18:09:57 UTC
Created attachment 274298 [details] [review]
Increase spacing between new game buttons
Comment 2 Michael Catanzaro 2014-04-14 21:11:47 UTC
OK, thanks.

Attachment 274298 [details] pushed as 28e4c4a - Increase spacing between new game buttons
Comment 3 Allan Day 2014-04-14 22:37:06 UTC
Created attachment 274311 [details]
screenshot and modified screenshot

Looks better, but now I notice that there's an uneven amount of padding between the buttons and between the buttons and the window edge

It would look a bit better if the padding is even. See the attachment - the image on top is an original screenshot. Underneath I've reduced the padding from 24px to 18px. This makes it even, which is a bit nicer.
Comment 4 Michael Catanzaro 2014-04-15 00:44:30 UTC
Created attachment 274323 [details] [review]
Reduce the space between the new game buttons

The amount of space outside the grid will always vary based on window size, but a bit smaller does seem to look better.