After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727928 - gapplication-tool fixes
gapplication-tool fixes
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gapplication
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-04-10 01:09 UTC by Cosimo Cecchi
Modified: 2014-04-10 16:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gapplication-tool: fix a typo (897 bytes, patch)
2014-04-10 01:09 UTC, Cosimo Cecchi 		committed Details | Review
gapplication-tool: ensure object paths are valid (941 bytes, patch)
2014-04-10 01:09 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2014-04-10 01:09:23 UTC 
See attached patches - the latter is more important because it prevents launching of apps that use hyphens in their ID through the gapplication tool.
Comment 1 Cosimo Cecchi 2014-04-10 01:09:25 UTC 
Created attachment 273950 [details] [review]
gapplication-tool: fix a typo

This must have never worked.
Comment 2 Cosimo Cecchi 2014-04-10 01:09:35 UTC 
Created attachment 273951 [details] [review]
gapplication-tool: ensure object paths are valid

Hyphens are not valid characters for DBus object paths; see the similar
code in gapplicationimpl-dbus.c
Comment 3 Emmanuele Bassi (:ebassi) 2014-04-10 08:52:43 UTC 
Review of attachment 273950 [details] [review]:

obviously correct.
Comment 4 Allison Karlitskaya (desrt) 2014-04-10 16:10:23 UTC 
Review of attachment 273951 [details] [review]:

If this matches the other behaviour, then please go ahead.
Comment 5 Cosimo Cecchi 2014-04-10 16:17:26 UTC 
Attachment 273950 [details] pushed as 59d1187 - gapplication-tool: fix a typo
Attachment 273951 [details] pushed as 9fe9a67 - gapplication-tool: ensure object paths are valid

Thanks, I pushed these to master and glib-2-40.