After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727881 - Port commandline option handling to GApplication
Port commandline option handling to GApplication
Status: RESOLVED FIXED
Product: gnome-screenshot
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-screenshot-maint
gnome-screenshot-maint
Depends on:
Blocks: 727882
 
 
Reported: 2014-04-09 08:04 UTC by Matthias Clasen
Modified: 2014-08-25 23:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port commandline option handling to GApplication (8.39 KB, patch)
2014-04-09 08:04 UTC, Matthias Clasen 		committed Details | Review
commandline args: parse delay parameter correctly (1.09 KB, patch)
2014-08-25 14:52 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Matthias Clasen 2014-04-09 08:04:36 UTC 
Use the facilities of GApplication for handling commandline
options.
Comment 1 Matthias Clasen 2014-04-09 08:04:46 UTC 
Created attachment 273856 [details] [review]
Port commandline option handling to GApplication
Comment 2 Cosimo Cecchi 2014-04-09 19:01:42 UTC 
Fixed up a couple of style issues and pushed to master, thanks!

Attachment 273856 [details] pushed as 989d75a - Port commandline option handling to GApplication
Comment 3 Dominique Leuenberger 2014-08-23 19:30:38 UTC 
This seems to have introduced the error that arguments to the commands are no longer honoured:

gnome-screenshot -d 5 for example takes a screenshot immediately
Comment 4 Matthias Clasen 2014-08-25 11:47:37 UTC 
Looks like a GApplication problem to me.
Comment 5 Allison Karlitskaya (desrt) 2014-08-25 14:52:59 UTC 
Created attachment 284410 [details] [review]
commandline args: parse delay parameter correctly

This is an int, not a uint.
Comment 6 Matthias Clasen 2014-08-25 14:57:53 UTC 
Review of attachment 284410 [details] [review]:

thanks for the fix
Comment 7 Dominique Leuenberger 2014-08-25 15:00:19 UTC 
For reference: bug 735323 was raised for the same; this one mentions that also -f is not working
Comment 8 Matthias Clasen 2014-08-25 15:39:03 UTC 
I've attached a similar patch there
Comment 9 Cosimo Cecchi 2014-08-25 23:03:59 UTC 
Attachment 284410 [details] pushed as 2c8e3b0 - commandline args: parse delay parameter correctly