That is not really true, we should still use GESTitleClip because this is how we are supposed to use GES API currently, but then, we should use the GESTitleSource API to set the various properties of the source.

Closing as NOTABUG.

OK, reopening it changing the title of the bug as it was not describing the problem properly

Created attachment 289472 [details] [review]
title-source: Properly expose children properties

+ Make sure that the TitleClip properties are not serialized anymore as
  they are serialized through children properties now.

+ Enhance debugging for not serialized properties in GESXmlFormatter.

Created attachment 289589 [details] [review]
title: Deprecate all method related to child properties

The standard way setting children properties is by using the
GESTrackElement::set_child_propery and friend methods

Created attachment 289590 [details] [review]
trackelement: Add a lookup_child vnethod

This method can be used for subclass to override the default behaviour
for child lookup. This vmethod can be used for example in the case where
you want the name of a child property to be 'overriden'.

As an ex example in the GESTitleSource where we have a videotestsrc
which has a 'foreground-color' property that is used in the TitleSource
to set the background color of the title, this vmethod is now used to
tweak the name passed has parametter to rename "background" to
"foreground-backend" making our API understandable.

API:
  GESTrackElement::lookup_child

Review of attachment 289472 [details] [review]:

OK

::: ges/ges-title-source.c
@@ -142,3 @@
 ges_title_source_create_source (GESTrackElement * object)
 {
-  GESTitleSource *self = GES_TITLE_SOURCE (object);

ain't no need to move that ?

::: ges/ges-xml-formatter.c
@@ +782,3 @@
+  }
+
+  return TRUE;

far more readable, cool

Review of attachment 289589 [details] [review]:

OK, didn't read in details to be honest :)

Review of attachment 289590 [details] [review]:

OK

::: ges/ges-track-element.c
@@ +136,3 @@
+  names = g_strsplit (prop_name, "::", 2);
+  if (names[1] != NULL) {
+    classename = names[0];

classe ?

Review of attachment 289590 [details] [review]:

::: ges/ges-track-element.c
@@ +136,3 @@
+  names = g_strsplit (prop_name, "::", 2);
+  if (names[1] != NULL) {
+    classename = names[0];

It is "la class" :P

Review of attachment 289472 [details] [review]:

::: ges/ges-title-source.c
@@ -142,3 @@
 ges_title_source_create_source (GESTrackElement * object)
 {
-  GESTitleSource *self = GES_TITLE_SOURCE (object);

I prefer to have:

1- Declarations without assignations
2- Declarations with assignations

Just a details

Attachment 289589 [details] pushed as 1906435 - title: Deprecate all method related to child properties