GNOME Bugzilla – Bug 727838
Some grilo fixes
Last modified: 2014-05-05 12:26:31 UTC
There's still a problem with rhythmbox not supporting media items at the root of the source, such as with the "Radio France" source in the latest grilo-plugins.
Created attachment 273809 [details] [review] grilo: Unregister ignored sources Instead of letting them running and using resources, unregister the sources that we ignore.
Created attachment 273810 [details] [review] grilo: Ignore video and image sources Instead of hard-coding many of the plugins, simply ignore sources that don't support audio types.
Review of attachment 273810 [details] [review]: ok
Review of attachment 273809 [details] [review]: ok
Created attachment 273890 [details] [review] this might help I can't test this at the moment (I don't have lua 5.2, so the lua-factory thing doesn't build, and I don't seem to have any other sources that put media in the root), but this might do roughly the right thing. It's probably a good idea to add something to the browser pane representing the root, since otherwise if you select a child container there's no way to get back. I might look at that later on.
(In reply to comment #5) > Created an attachment (id=273890) [details] [review] > this might help > > I can't test this at the moment (I don't have lua 5.2, so the lua-factory thing > doesn't build, and I don't seem to have any other sources that put media in the > root), but this might do roughly the right thing. > > It's probably a good idea to add something to the browser pane representing the > root, since otherwise if you select a child container there's no way to get > back. I might look at that later on. Much better, I actually see the items in the list though, as you mention, it would be good to hide the "browse" pane if there are no children to that list. The other problem is that the "album art" is wrong except for the first played radio station, this is likely due to the radio stations lacking both artist and album values (they only have titles). If that's any help, Fedora 20 has lua 5.2 builtin. My attempts at making it work with lua 5.1 failed as lua 5.1 is lacking a way to load libraries from the C api (we preload the grilo API for all the scripts).
Created attachment 274087 [details] [review] somewhat better I've tried this out with a few things and seems okay. Rather than hiding the browser, I'm adding an item representing the root if we find any media in there in the initial browse. I don't have any sources that have media in the root and also a container hierarchy, but I think if that happens it should work.
That works well, thanks!
Pushed as commit 75894d6; thanks for testing.
other things pushed, closing