After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727829 - win32: glibconfig.h.win32 updates
win32: glibconfig.h.win32 updates
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: win32
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-win32 maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-08 13:03 UTC by Philip Withnall
Modified: 2015-06-25 09:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Update glibconfig.h.win32.in (1.26 KB, patch)
2014-04-08 13:03 UTC, Philip Withnall 		committed Details | Review
build: Ensure glibconfig.h.win32 is in DISTCLEANFILES (1.35 KB, patch)
2014-04-08 13:03 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2014-04-08 13:03:49 UTC 
A couple of patches with some minor updates to glibconfig.h.win32, plus a build fix to try and ensure it doesn’t stay stale in a build tree.
Comment 1 Philip Withnall 2014-04-08 13:03:52 UTC 
Created attachment 273801 [details] [review]
build: Update glibconfig.h.win32.in

Update it to match recent changes in the construction of glibconfig.h.
Comment 2 Philip Withnall 2014-04-08 13:03:55 UTC 
Created attachment 273802 [details] [review]
build: Ensure glibconfig.h.win32 is in DISTCLEANFILES

Otherwise it’s possible for it to not be regenerated when glibconfig.h
is, leading to inconsistencies.
Comment 3 Fan, Chun-wei 2015-01-07 02:13:35 UTC 
Review of attachment 273801 [details] [review]:

Hello Philip,

Thanks for the heads-up for me that glibconfig.h needs to be updated-I have committed updates to it based on your patch in both master (as 1632d57) and glib-2-42 (as 7d8e194).  Just a note, I also updated the part on the 32-bit builds, as your patch for the modifiers only addressed the x64 builds.

I am perhaps not the best person to look at the autotools part for this bug though, just to let you know.

With blessings, thank you!
Comment 4 Philip Withnall 2015-06-25 09:43:30 UTC 
Timed out and pushed the remaining fix, since nobody has complained and it seems fairly straightforward.

Attachment 273802 [details] pushed as 409202c - build: Ensure glibconfig.h.win32 is in DISTCLEANFILES