GNOME Bugzilla – Bug 727813
** (sound-juicer:17126): WARNING **: Unknown country code: XE
Last modified: 2014-04-09 12:19:17 UTC
This is caused by the addition of country lookup, happens with http://musicbrainz.org/release-group/80695510-daef-36a7-b048-8deef6c7ba5c for example. XE is apparently Europe for some definition of it. Dunno if this is something musicbrainz specific or if this will eventually appear in iso-codes ( iso-codes-3.49-1.fc20.noarch )
It's musicbrainz specific (https://musicbrainz.org/doc/Release_Country) I didn't realize they add some extra codes on top of the standard iso3166-1 codes when I wrote the country lookup stuff. There are only a few extra codes, I could add the translated names to the hash table that's populated from the iso-codes data and assume that they'll pass through dgettext ("iso_3166", country_name) unchanged or just test for them if the hash table lookup fails - what do you think is best? The extra codes are XC Czechoslovakia XG East Germany XE Europe CS Serbia and Montenegro SU Soviet Union XU Unknown Country XW Worldwide YU Yugoslavia
I'd test for them if the hash table lookup fails, this way we can mark them for translation.
Created attachment 273874 [details] [review] Add MusicBrainz specific county codes Musicbrainz uses some additional codes on top of ISO-3166 which were not handled by commit d2d8da5 - Get country name ISO code. Treat these extra codes as a special case if we don't get a match from the iso-codes data.
Review of attachment 273874 [details] [review]: 'county' instead of 'country' in the commit shortlog, looks good otherwise, thanks!
Attachment 273874 [details] pushed as commit 6df6b37 - Add MusicBrainz specific country codes