After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727812 - directsoundsrc: CRITICAL, debug category not defined
directsoundsrc: CRITICAL, debug category not defined
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-08 10:43 UTC by Xavi Artigas
Modified: 2014-04-08 11:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Trivial fix (1.12 KB, patch)
2014-04-08 10:43 UTC, Xavi Artigas 		needs-work Details | Review
trivil fix (1.46 KB, patch)
2014-04-08 11:26 UTC, Xavi Artigas 		committed Details | Review

Description Xavi Artigas 2014-04-08 10:43:35 UTC 
Created attachment 273775 [details] [review]
Trivial fix

In directsoundsrc.c:161 (gst_directsound_src_class_init):

  GST_DEBUG ("initializing directsoundsrc class");

But the debug category is not defined until line 181:

  GST_DEBUG_CATEGORY_INIT (directsoundsrc_debug, "directsoundsrc", 0,
      "DirectSound Src");

Therefore, we get this annoying (although harmless) Glib Critical:

GStreamer-CRITICAL **: gst_debug_log_valist: assertion 'category != NULL' failed
Comment 1 Sebastian Dröge (slomo) 2014-04-08 11:13:19 UTC 
Comment on attachment 273775 [details] [review]
Trivial fix

Can you attach this in "git format-patch" format?
Comment 2 Xavi Artigas 2014-04-08 11:26:10 UTC 
Created attachment 273782 [details] [review]
trivil fix

Patch in git format-patch format now.
Comment 3 Sebastian Dröge (slomo) 2014-04-08 11:39:35 UTC 
commit e12646f30a66e0d9f5586f5cb64963d728f081ca
Author: Xavi Artigas <xartigas@fluendo.com>
Date:   Tue Apr 8 13:20:54 2014 +0200

    directsoundsrc: Fix critical due to missing debug category initialization
    
    https://bugzilla.gnome.org/show_bug.cgi?id=727812