After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727804 - Address book dialog - design updates
Address book dialog - design updates
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
available
: 722150 727910 (view as bug list)
Depends on:
Blocks: 727842
 
 
Reported: 2014-04-08 09:04 UTC by Allan Day
Modified: 2014-04-10 19:48 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12


Attachments
Update the address book dialog to the new design (2.65 KB, patch)
2014-04-09 18:50 UTC, Yosef Or Boczko
none Details | Review
Use the new API's for the address book dialog (2.03 KB, patch)
2014-04-09 18:51 UTC, Yosef Or Boczko
none Details | Review
Use the address book icon instead the hard drive one (1.57 KB, patch)
2014-04-09 19:01 UTC, Yosef Or Boczko
none Details | Review

Description Allan Day 2014-04-08 09:04:12 UTC
The design of the address book dialog needed tightening up a bit. Specific issues with it:

 * "Primary Contacts Account" is ambiguous, and isn't consistent with the app menu item. Change it to: "Change Address Book".
 * "Done" button should be insensitive until the address book is changed (this is an action dialog - http://wiki.gnome.org/Design/HIG/Dialogs).
 * Reduce the padding around the list - I think this is neater.
 * Use the address book icon for the local address book (people won't know what a hard drive looks like).
 * Add an explanation for how the dialog works.

There are also a few small UI issues with the version in 3.12:

 * Header bar buttons are too tall - they should have the regular button height.
 * The title and the subtitle of each account are a bit far from each other. It doesn't look tidy.

Updated mockup:

https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/edf29350917fdd12d9125741971a5f59e90eb1c4/contacts/png/accounts-dialog.png
Comment 1 Allan Day 2014-04-08 16:09:02 UTC
*** Bug 722150 has been marked as a duplicate of this bug. ***
Comment 2 Allan Day 2014-04-09 18:43:04 UTC
*** Bug 727910 has been marked as a duplicate of this bug. ***
Comment 3 Yosef Or Boczko 2014-04-09 18:50:59 UTC
Created attachment 273927 [details] [review]
Update the address book dialog to the new design
Comment 4 Yosef Or Boczko 2014-04-09 18:51:13 UTC
Created attachment 273928 [details] [review]
Use the new API's for the address book dialog
Comment 5 Yosef Or Boczko 2014-04-09 19:01:18 UTC
Created attachment 273929 [details] [review]
Use the address book icon instead the hard drive one
Comment 6 Allan Day 2014-04-09 21:19:01 UTC
Thanks for working on this, Yosef. The text in the screenshot you posted to bug 
727910 is missing the word "other":

https://bug727910.bugzilla-attachments.gnome.org/attachment.cgi?id=273926

Also, I spotted a design error: the button should read "Change" rather than "Done".
Comment 7 Erick Perez Castellanos 2014-04-10 19:47:15 UTC
Fixed in master.
Pushed here: https://git.gnome.org/browse/gnome-contacts/commit/?id=29268955d0d01e6ad963cccf7b7835fcb9a23b18
Comment 8 Erick Perez Castellanos 2014-04-10 19:48:13 UTC
(In reply to comment #3)
> Created an attachment (id=273927) [details] [review]
> Update the address book dialog to the new design

I had already this fixed on my repo in my pc. Sorry.
We should coordinate the efforts so we don't waste manpower.