GNOME Bugzilla – Bug 727709
Check system_bus before unref
Last modified: 2014-05-10 16:39:47 UTC
In gupnp_context_manager_create() system_bus unreffed after obtained it. But could be that it is not running. So we need to check the object before unreffing it.
Created attachment 273667 [details] [review] Check system_bus before unref
I think we could short-cut the check for connman/NetworkManager availability as well then; without system bus, they won't work. Would you mind adding that and commit the patch? Otherwise just commit this patch and I'll do the rest later.
I'll do
Created attachment 273768 [details] [review] Check if system-bus is accessible Not sure if this is what you meant.
Created attachment 276288 [details] [review] Prevent critical if there's no system bus Found by Juan A. Suarez Romero <jasuarez@igalia.com> Signed-off-by: Jens Georg <mail@jensge.org> I slightly modified it to use g_clear_object
Created attachment 276290 [details] [review] Check for system bus before using DBus If there's no system bus, there's no need to check for Connman or NetworkManager availability. Signed-off-by: Jens Georg <mail@jensge.org>
Attachment 276288 [details] pushed as 7507049 - Prevent critical if there's no system bus Attachment 276290 [details] pushed as dd6008c - Check for system bus before using DBus