GNOME Bugzilla – Bug 727688
Layer menu icon looks fuzzy on hidpi screen
Last modified: 2014-10-13 08:14:15 UTC
The icon inside the layer menu button looks fuzzy on my hidpi screen. I'm guessing that it's pixel scaled for some reason.
All we need to do apparently is follow this guide for the icons to be themable app specific icons which will make them scale automatically: https://wiki.gnome.org/DraftSpecs/ThemableAppSpecificIcons
Created attachment 282191 [details] [review] Align escaped newlines Align all escaped newlines at column 72, like in the rest of the Makefiles. Don't align the icon handling stuff since it comes from another code base.
Created attachment 282192 [details] [review] Use real scalable icons Use installed icons instead of including icons inside the data resource. This makes it possible for GDk to scale the icons manually and also seems to be the preferred way to deal with icons.
Review of attachment 282191 [details] [review]: Ack from 9ans vagn
Review of attachment 282192 [details] [review]: Looks nice. Are these all icons? How about the pin ams nubble?
Review of attachment 282192 [details] [review]: The Pin and bubble aren't icons really (in the sense of scaleable symbolic icons at least) and are loaded via Utils.CreateActorFromImageFile. I think this means that they shouldn't be covered by this (and they aren't fuzzy on my hidpi screen either). They should probably be moved into the gresource though (but that's for a later patch in that case). I'll try to get a review on this from one of the gtk+-ers here at guadec tomorrow. It might be that some of these icons should be installed "privately" instead and that they should be made in some specific way so that they can be recolored when the background changes (for example when selecting a row in the sidebar searchresult listbox or when switching to the dark theme).
Created attachment 288363 [details] [review] Align newline escaping Align newline escaping like in other Makefiles.
Created attachment 288364 [details] [review] Move to symbolic direction icons
There was a commit lately that fixed most of this bug but the routing icons remain (they weren't symbolic and they didn't scale on Hi-DPI screens). I produced a new patch for those and attached above. My hope is for these to land for 3.14.1 but I understand that I'm a bit late.
Review of attachment 288363 [details] [review]: Ack (o/
Review of attachment 288364 [details] [review]: Thanks! So now we get white background on the direction icons, is that worth mentioning in the commit log? Also it seems alignment is an issue? See attached ss.
Created attachment 288365 [details] Route instruction list Should the direction icons be aligned with the 'start' icon?
Created attachment 288366 [details] [review] sidebar: Fix alignment of instruction icons The start/stop icons are 16x16 and the direction hints are 32x32. To ensure aligmnent in the instruction list we need to make sure the GtkImage always has a 32x32 width.
Attachment 288366 [details] pushed as 7c069ba - sidebar: Fix alignment of instruction icons