After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727615 - cli: don't require a next-hop for routes
cli: don't require a next-hop for routes
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nmcli
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-04-04 16:22 UTC by Dan Williams
Modified: 2014-06-11 08:31 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dan Williams 2014-04-04 16:22:02 UTC
This prevents adding device routes, which I think should be allowed.  The editor doesn't require a next-hop either.

I think any of these should work:

set ipv4.routes 1.2.3.0/24
set ipv4.routes 1.2.3.0/24 10
set ipv4.routes 1.2.3.0/24 1.2.3.1 10

thoughts?
Comment 1 Jiri Klimes 2014-06-10 16:20:02 UTC
Yeah, it should be done.

Patches for both IPv4 and IPv6 are in jk/cli-routes-bgo727615 branch.
Comment 2 Dan Williams 2014-06-10 22:16:15 UTC
Looks good to me.  Seems to work well in some light testing.
Comment 3 Thomas Haller 2014-06-11 05:46:11 UTC
LGTM too
Comment 4 Jiri Klimes 2014-06-11 08:31:53 UTC
Commits in master:
e70d557 cli: don't accept prefix 0 for routes
4e9fc8a cli: don't accept default route entries, NM handles the default route itself
700f5ec cli: allow missing next hop for routes (bgo #727615)

Also cherry-picked to nm-0-9-10.