Bug 727604 – Crash in _pygi_marshal_from_py_interface_object with invalid input value

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 727604 - Crash in _pygi_marshal_from_py_interface_object with invalid input value


Summary:	Crash in _pygi_marshal_from_py_interface_object with invalid input value


Status:	RESOLVED FIXED

Product:	pygobject
Classification:	Bindings
Component:	general
Version:	3.12.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Nobody's working on this now (help wanted and appreciated)
QA Contact:	Python bindings maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2014-04-04 12:48 UTC by Christoph Reiter (lazka)
Modified:	2014-04-14 22:58 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description Christoph Reiter (lazka) 2014-04-04 12:48:12 UTC

The following crashes with 3.12.0 but didn't with 3.10.2

################
from gi.repository import Gtk
action = Gtk.RadioAction("", "", None, None, 0)
action.join_group(1)  # <- crash instead of TypeError
################

Program received signal SIGSEGV, Segmentation fault.
_pygi_marshal_from_py_interface_object (state=<optimized out>, callable_cache=<optimized out>, 
    arg_cache=0xb97360, py_arg=1, arg=0xc457c8, cleanup_data=0x7fffffffdc00) at pygi-object.c:142
142	            !g_type_is_a (G_OBJECT_TYPE (gobj), iface_cache->g_type)) {

+ Trace 233434

#0 _pygi_marshal_from_py_interface_object
at pygi-object.c line 142
#1 _invoke_marshal_in_args
at pygi-invoke.c line 580
#2 pygi_callable_info_invoke
#3 _wrap_g_callable_info_invoke
#4 _callable_info_call
#5 PyObject_Call
#6 do_call
at ../Python/ceval.c line 4238
#7 call_function
at ../Python/ceval.c line 4043
#8 PyEval_EvalFrameEx
#9 PyEval_EvalCodeEx
at ../Python/ceval.c line 3252
#10 PyEval_EvalCode
at ../Python/ceval.c line 667
#11 run_mod
#12 PyRun_FileExFlags
#13 PyRun_SimpleFileExFlags
at ../Python/pythonrun.c line 948
#14 PyRun_AnyFileExFlags
at ../Python/pythonrun.c line 752
#15 Py_Main
at ../Modules/main.c line 640
#16 __libc_start_main
at libc-start.c line 287
#17 _start

Comment 1 Simon Feltman 2014-04-04 22:40:30 UTC

Related commits which caused the regression:
https://git.gnome.org/browse/pygobject/commit/?id=d5925b76
https://git.gnome.org/browse/pygobject/commit/?id=9b345b1