Bug 727536 – Crashes when trying to save a copy

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 727536 - Crashes when trying to save a copy


Summary:	Crashes when trying to save a copy


Status:	RESOLVED FIXED

Product:	evince
Classification:	Core
Component:	general
Version:	3.12.x
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Evince Maintainers
QA Contact:	Evince Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2014-04-03 11:25 UTC by Debarshi Ray
Modified:	2014-04-04 08:50 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
ev-window: Don't crash when trying to save a copy (1.60 KB, patch) 2014-04-03 11:45 UTC, Debarshi Ray	committed	Details \| Review

Description Debarshi Ray 2014-04-03 11:25:56 UTC

Open any PDF (could affect other formats too) and try to save a copy from the gear menu. It will crash with the following backtrace:

(gdb) bt

+ Trace 233429

#0 __GI_raise
at ../nptl/sysdeps/unix/sysv/linux/raise.c line 56
#1 __GI_abort
at abort.c line 89
#2 __libc_message
at ../sysdeps/posix/libc_fatal.c line 175
#3 malloc_printerr
#4 _int_free
at malloc.c line 3782
#5 g_free
at gmem.c line 190
#6 ev_window_file_chooser_restore_folder
at ev-window.c line 2457
#7 ev_window_cmd_save_as
at ev-window.c line 3006
#8 g_closure_invoke
at gclosure.c line 768
#9 signal_emit_unlocked_R
at gsignal.c line 3551
#10 g_signal_emit_valist
at gsignal.c line 3307
#11 g_signal_emit
at gsignal.c line 3363
#12 _gtk_action_emit_activate
at deprecated/gtkaction.c line 909
#13 g_closure_invoke
at gclosure.c line 768
#14 signal_emit_unlocked_R
at gsignal.c line 3481
#15 g_signal_emit_valist
at gsignal.c line 3307
#16 g_signal_emit
at gsignal.c line 3363
#17 gtk_widget_activate
at gtkwidget.c line 7259
#18 gtk_menu_shell_activate_item
at gtkmenushell.c line 1378
#19 gtk_menu_shell_button_release
at gtkmenushell.c line 792
#20 _gtk_marshal_BOOLEAN__BOXEDv
at gtkmarshalers.c line 130
#21 _g_closure_invoke_va
at gclosure.c line 831
#22 g_signal_emit_valist
at gsignal.c line 3215
#23 g_signal_emit
at gsignal.c line 3363
#24 gtk_widget_event_internal
at gtkwidget.c line 7228
#25 gtk_widget_event
at gtkwidget.c line 6890
#26 propagate_event_up
at gtkmain.c line 2406
#27 propagate_event
at gtkmain.c line 2514
#28 gtk_main_do_event
at gtkmain.c line 1735
#29 gdk_event_source_dispatch
at gdkeventsource.c line 364
#30 g_main_dispatch
at gmain.c line 3064
#31 g_main_context_dispatch
at gmain.c line 3663
#32 g_main_context_iterate
at gmain.c line 3734
#33 g_main_context_iteration
at gmain.c line 3795
#34 g_application_run
at gapplication.c line 2114
#35 main
at main.c line 316


I tried evince-3.12.0 and the gnome-3-12 branch.

Comment 1 Debarshi Ray 2014-04-03 11:36:15 UTC

This is a fallout from:

commit 41ce0e16cc3f395766abb239f990dd98c3144001
Author: Christian Persch <chpe@gnome.org>
Date:   Thu Feb 13 13:58:57 2014 +0100

    shell: Fix potential read-after-free in gsettings use
    
    It's not valid to use '&' with g_settings_get().
    
    https://bugzilla.gnome.org/show_bug.cgi?id=723737

Comment 2 Debarshi Ray 2014-04-03 11:45:44 UTC

Created attachment 273521 [details] [review]
ev-window: Don't crash when trying to save a copy

Comment 3 Carlos Garcia Campos 2014-04-03 17:01:12 UTC

Comment on attachment 273521 [details] [review]
ev-window: Don't crash when trying to save a copy

Thanks!. Please push it to both brtanches.