After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727530 - Void function should not return a value
Void function should not return a value
Status: RESOLVED FIXED
Product: libgweather
Classification: Core
Component: general
unspecified
Other FreeBSD
: Normal normal
: future
Assigned To: libgweather-maint
libgweather-maint
: 728037 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-04-03 09:39 UTC by Ting-Wei Lan
Modified: 2014-04-23 08:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix "void function should not return a value" error for clang (860 bytes, patch)
2014-04-03 09:39 UTC, Ting-Wei Lan 		accepted-commit_now Details | Review

Description Ting-Wei Lan 2014-04-03 09:39:03 UTC 
Created attachment 273510 [details] [review]
Fix "void function should not return a value" error for clang

I get this error when compiling libgweather:

gweather-location.c:767:5: error: void function 'gweather_location_detect_nearest_city' should not return a value [-Wreturn-type]

gweather_location_detect_nearest_city uses g_return_val_if_fail in libgweather/gweather-location.c, and it should be changed to g_return_if_fail.
Comment 1 Javier Jardón (IRC: jjardon) 2014-04-17 09:34:46 UTC 
Comment on attachment 273510 [details] [review]
Fix "void function should not return a value" error for clang

looks good
Comment 3 Koop Mast (kwm) 2014-04-23 08:29:09 UTC 
*** Bug 728037 has been marked as a duplicate of this bug. ***