After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727499 - W32: shared libraries can't be built
W32: shared libraries can't be built
Status: RESOLVED FIXED
Product: libpeas
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libpeas-maint
libpeas-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-02 15:50 UTC by LRN
Modified: 2014-06-28 12:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
W32: Allow shared libs to be built (6.89 KB, patch)
2014-04-02 15:50 UTC, LRN 		none Details | Review
W32: Allow shared libs to be built (v2) (8.02 KB, patch)
2014-04-03 06:32 UTC, LRN 		committed Details | Review

Description LRN 2014-04-02 15:50:11 UTC 
Libtool refuses to make shared libraries without -no-undefined,
and refuses to make shared libraries with -no-undefined when there are
undefined references.
Comment 1 LRN 2014-04-02 15:50:14 UTC 
Created attachment 273484 [details] [review]
W32: Allow shared libs to be built

This requires -no-undefined flag and resolving all dependencies at link-time by
linking plugins to libpeas and libpeas-gtk as needed.
Comment 2 Ignacio Casal Quinteiro (nacho) 2014-04-03 06:22:15 UTC 
For me it looks good, let's wait for an extra ack from Garret. Although there is one missing point, the seed loader should be modified to add also the direct link to libpeas.
Comment 3 LRN 2014-04-03 06:32:05 UTC 
Created attachment 273502 [details] [review]
W32: Allow shared libs to be built (v2)

This requires -no-undefined flag and resolving all dependencies at link-time by
linking plugins to libpeas and libpeas-gtk as needed.

v2: Added (untested, but identical, so, hopefully, they work) changes to
python3 loader and seed loader.
Comment 4 Garrett Regier 2014-05-29 17:55:37 UTC 
Comment on attachment 273502 [details] [review]
W32: Allow shared libs to be built (v2)

Hey sorry for the delay, looks good. Feel free to commit.
Comment 5 Garrett Regier 2014-06-28 12:51:20 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.