After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727487 - Color picker check marks not cleared properly
Color picker check marks not cleared properly
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-04-02 10:27 UTC by Jan Alexander Steffens (heftig)
Modified: 2014-04-14 05:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot (44.95 KB, image/png)
2014-04-02 10:27 UTC, Jan Alexander Steffens (heftig) 		  Details
A small program demonstrating the bug (593 bytes, text/x-csrc)
2014-04-12 10:13 UTC, Marcus Karlsson 		  Details
Proposed patch (1.47 KB, patch)
2014-04-12 10:20 UTC, Marcus Karlsson 		committed Details | Review

Description Jan Alexander Steffens (heftig) 2014-04-02 10:27:12 UTC 
Created attachment 273461 [details]
Screenshot

Selecting another color swatch does not clear the check mark from the previously selected one. The check mark is only cleared when that swatch is redrawn (e.g. through hover or focus change).

gtk3 3.12.0
Thinkpad X220t (Arch Linux x86_64, Intel graphics)
Comment 1 Matthias Clasen 2014-04-02 13:55:18 UTC 
not happening here.
Comment 2 Marcus Karlsson 2014-04-12 10:13:48 UTC 
Created attachment 274157 [details]
A small program demonstrating the bug

I'm able to reproduce this bug.

I have created a small program that demonstrates this by creating a single window with a GtkColorChooserWidget. This will run as expected when the bright Adwaita theme is used, but not when the dark theme or no theme is used (ie. when GTK_DATA_PREFIX is set to an empty string).

When using the dark Adwaita theme the behavior matches the screenshot in the original post. When no theme is used the behavior is a bit different; then the selected swatch will not have the checkbox drawn until it looses focus, but the previously selected swatches will still have them.
Comment 3 Marcus Karlsson 2014-04-12 10:20:50 UTC 
Created attachment 274158 [details] [review]
Proposed patch

Here is a patch that attempts to fix the problem. The previously selected swatch and the currently selected swatch are redrawn when a swatch is selected.