After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727418 - h264 encoder: minor enhancement patches
h264 encoder: minor enhancement patches
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 720305
 
 
Reported: 2014-04-01 08:33 UTC by sreerenj
Modified: 2014-06-03 12:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
encoder: h264: Restrict the usage of cabac in ExtendedProfile. (1000 bytes, patch)
2014-04-01 08:33 UTC, sreerenj 		accepted-commit_now Details | Review
encoder: h264: Remove unnecessary calcualtion of max_pic_order_cnt (936 bytes, patch)
2014-04-01 08:33 UTC, sreerenj 		reviewed Details | Review
encoder: h264: Don't use CABAC in ExtendedProfile (1002 bytes, patch)
2014-04-07 07:42 UTC, sreerenj 		none Details | Review

Description sreerenj 2014-04-01 08:33:12 UTC 
Created attachment 273386 [details] [review]
encoder: h264: Restrict the usage of cabac in ExtendedProfile.

Adding some minor patches to enhance the h264_encoder.
Comment 1 sreerenj 2014-04-01 08:33:44 UTC 
Created attachment 273387 [details] [review]
encoder: h264: Remove unnecessary calcualtion of  max_pic_order_cnt
Comment 2 Gwenole Beauchesne 2014-04-01 20:36:05 UTC 
Review of attachment 273386 [details] [review]:

This should read: "there is no CABAC entropy coding mode". i.e. "no". :)
Comment 3 Gwenole Beauchesne 2014-04-01 20:39:20 UTC 
Review of attachment 273387 [details] [review]:

Maybe could we just use encoder->max_pic_order_cnt? Will change that on commit. Thanks.
Comment 4 sreerenj 2014-04-07 07:29:38 UTC 
(In reply to comment #2)
> Review of attachment 273386 [details] [review]:
> 
> This should read: "there is no CABAC entropy coding mode". i.e. "no". :)

Sorry for the stupid, misleading commit message :(. Will change it. Thanks for the review
Comment 5 sreerenj 2014-04-07 07:42:13 UTC 
Created attachment 273687 [details] [review]
encoder: h264: Don't use CABAC in ExtendedProfile
Comment 6 Gwenole Beauchesne 2014-06-03 12:33:06 UTC 
commit e1976df1a13e5f6bd3c7d07c8700f065bcb2663e
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Tue Apr 1 11:26:04 2014 +0300

    encoder: h264: remove unnecessary calcualtion of max_pic_order_cnt.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=727418

commit 6df5c7408133fdfec5eee5cf5d82039d2c418f3b
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Tue Apr 1 14:23:56 2014 +0300

    encoder: h264: don't allow CABAC with Extended profile.
    
    The H.264 specification does not support CABAC entropy coding for the
    Extended profile.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=727418