After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727410 - W32: tooltips are not themed
W32: tooltips are not themed
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-04-01 02:41 UTC by LRN
Modified: 2014-04-04 10:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
W32: style tooltips with appropriately-themed background (1.03 KB, patch)
2014-04-01 02:41 UTC, LRN 		committed Details | Review
How tooltips look without the patch (1.76 KB, image/png)
2014-04-01 02:41 UTC, LRN 		  Details
How tooltips look with the patch (1.99 KB, image/png)
2014-04-01 02:43 UTC, LRN 		  Details

Description LRN 2014-04-01 02:41:04 UTC 
Tooltips have a part for theming background, it should be used.
Comment 1 LRN 2014-04-01 02:41:10 UTC 
Created attachment 273368 [details] [review]
W32: style tooltips with appropriately-themed background
Comment 2 LRN 2014-04-01 02:41:34 UTC 
Created attachment 273369 [details]
How tooltips look without the patch
Comment 3 LRN 2014-04-01 02:43:56 UTC 
Created attachment 273370 [details]
How tooltips look with the patch

On XP there's no difference, as XP theme's idea of tooltip background is the same as unpatched CSS draws (since it does get correct color values from the system, and border color and width happen to be the same).
Comment 4 Ignacio Casal Quinteiro (nacho) 2014-04-01 12:33:41 UTC 
Review of attachment 273368 [details] [review]:

Looks good.
Comment 5 LRN 2014-04-04 09:41:57 UTC 
Attachment 273368 [details] pushed as 42f7071 - W32: style tooltips with appropriately-themed background