After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727392 - Properties dialog should have a X close button - not "Done"
Properties dialog should have a X close button - not "Done"
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.12.x
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
: 733215 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-03-31 16:19 UTC by Pranav Kant
Modified: 2014-07-15 16:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Properties: Use a X close button instead of "Done" (959 bytes, patch)
2014-04-01 13:29 UTC, Saurav Agarwalla 		committed Details | Review

Description Pranav Kant 2014-03-31 16:19:47 UTC 
The properties dialog is a presentation dialog:
https://wiki.gnome.org/Design/HIG/Dialogs#Presentation_Dialogs

It should have a close button in the corner of the header bar (like standard
window header bars), not a "Done" button.
Comment 1 Saurav Agarwalla 2014-04-01 13:29:59 UTC 
Created attachment 273402 [details] [review]
Properties: Use a X close button instead of "Done"

As per the commit for Bug 727301.
Comment 2 Debarshi Ray 2014-04-01 14:17:23 UTC 
Review of attachment 273402 [details] [review]:

Thanks for the patch Saurav! Looks good to me.
Comment 3 Debarshi Ray 2014-07-15 16:37:48 UTC 
*** Bug 733215 has been marked as a duplicate of this bug. ***