After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727310 - Function has incorrect signature
Function has incorrect signature
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.12.x
Other Linux
: Normal trivial
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-29 17:47 UTC by Ross Lagerwall
Modified: 2014-03-30 06:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
window: Use the return type (1002 bytes, patch)
2014-03-29 17:49 UTC, Ross Lagerwall
committed Details | Review

Description Ross Lagerwall 2014-03-29 17:47:50 UTC
notebook_switch_page_cb() in nautilus-window.c returns a gboolean when, according to the GTK+ 3 docs, it should be void.
Comment 1 Ross Lagerwall 2014-03-29 17:49:31 UTC
Created attachment 273243 [details] [review]
window: Use the return type
Comment 2 Cosimo Cecchi 2014-03-29 23:50:36 UTC
Review of attachment 273243 [details] [review]:

Sure, looks good.
Comment 3 Ross Lagerwall 2014-03-30 06:39:52 UTC
Pushed to master as 4004ddbd4665b93dc83fb6ac590e7f6ca38d8c38. Thanks!