GNOME Bugzilla – Bug 727257
Bookmarks/contents dialog - close button
Last modified: 2014-04-03 11:12:36 UTC
The bookmarks/contents dialog has a "Close" button in the top right of the header bar. As this is a presentation dialog, the close button shouldn't have a text label - it should have a close button like standard window header bars. See: https://wiki.gnome.org/Design/HIG/Dialogs#Presentation_Dialogs
Created attachment 273478 [details] [review] Replaces Close button with standard x from bookmarks/contents dialog
Review of attachment 273478 [details] [review]: Thanks for the nice patch Marta. Could you please add the URL of this bug to the commit message? (You could try out git-bz.) ::: src/places.js @@ -54,3 @@ title: "", hexpand: true }); - this.widget.add_button(_("Close"), Gtk.ResponseType.CLOSE); Maybe we should use DELETE_EVENT instead of CLOSE a few lines below in _handleLink and _handleBookmark for the sake of consistency?
Created attachment 273487 [details] [review] Replace "Close" button with standard "x" from bookmarks/contents dialog Updated! Bookmarks/contents dialog is a presentation dialog and it shouldn't have close button with the label "Close". This patch adds standard close_button to the dialog.
Thank you Debarshi for the review and advice. From now on only git-bz... it's great :)
Review of attachment 273487 [details] [review]: Perfect. Thanks, Marta. I tweaked your commit message a bit because we don't need the "Updated!" in there.
Great, thank you!