After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727244 - W32: Items selected in listbox have correct background color, but wrong text color
W32: Items selected in listbox have correct background color, but wrong text ...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-03-28 13:48 UTC by LRN
Modified: 2014-04-04 08:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
W32: Fix listbox selection (5.16 KB, patch)
2014-03-28 13:48 UTC, LRN
committed Details | Review
W32: Give unfocused selected list items special background, like Explorer does (1.08 KB, patch)
2014-04-02 17:49 UTC, LRN
committed Details | Review
How selected & unfocused item looks without patch 273488 (but with patch 273170) (16.93 KB, image/png)
2014-04-02 17:51 UTC, LRN
  Details
How selected & unfocused item looks with patch 273488 on top of patch 273170 (16.93 KB, image/png)
2014-04-02 17:51 UTC, LRN
  Details

Description LRN 2014-03-28 13:48:24 UTC
Turns out, W32 CSS doesn't have any .list and .list-row styles,
and once these are added, they may not work correctly with existing styles.
I've made a quick hack to fix this, but i would recommend W32 stylesheet to
be completely redone eventually, to avoid blanket styles.
Comment 1 LRN 2014-03-28 13:48:35 UTC
Created attachment 273170 [details] [review]
W32: Fix listbox selection

* Makes listbox background white instead of default grey
* Uses gradients or W32 theme parts to draw sexy selection/prelight
  rectangle instead of changing selected/prelighted item background
* Removes blanket button text color, allowing buttons to inherit
  text color from their parents. Non-normal buttons DO get specific
  text color though. This partially fixes text color propagation from
  listbox rows to their children.
Comment 2 Matthias Clasen 2014-03-28 19:03:50 UTC
Review of attachment 273170 [details] [review]:

ok
Comment 3 LRN 2014-04-02 17:49:53 UTC
Created attachment 273488 [details] [review]
W32: Give unfocused selected list items special background, like Explorer does
Comment 4 LRN 2014-04-02 17:51:20 UTC
Created attachment 273489 [details]
How selected & unfocused item looks without patch 273488 (but with patch 273170)
Comment 5 LRN 2014-04-02 17:51:47 UTC
Created attachment 273490 [details]
How selected & unfocused item looks with patch 273488 on top of patch 273170
Comment 6 Ignacio Casal Quinteiro (nacho) 2014-04-03 22:15:34 UTC
Review of attachment 273488 [details] [review]:

Looks good.
Comment 7 LRN 2014-04-04 08:02:29 UTC
Attachment 273170 [details] pushed as e229cff - W32: Fix listbox selection
Attachment 273488 [details] pushed as 3540e6c - W32: Give unfocused selected list items special background, like Explorer does