After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727221 - e-util: Port to thread-safe ECategories API
e-util: Port to thread-safe ECategories API
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
3.11.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2014-03-28 09:18 UTC by Philip Withnall
Modified: 2014-03-28 10:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
e-util: Port to thread-safe ECategories API (22.58 KB, patch)
2014-03-28 09:18 UTC, Philip Withnall
committed Details | Review

Description Philip Withnall 2014-03-28 09:18:24 UTC
This is a follow-up from bug #727137, porting Evolution to use the new thread-safe ECategories API.

This patch hasn't been thoroughly tested.
Comment 1 Philip Withnall 2014-03-28 09:18:27 UTC
Created attachment 273153 [details] [review]
e-util: Port to thread-safe ECategories API

This ports the following two function calls throughout Evolution:
 • e_categories_get_list() to e_categories_dup_list()
 • e_categories_get_icon_file_for() to e_categories_dup_icon_file_for()

It necessarily changes some internal e-util API:
 • e_util_get_searchable_categories() to
   e_util_dup_searchable_categories()

This bumps the EDS requirement to 3.13.1.
Comment 2 Milan Crha 2014-03-28 10:09:28 UTC
Review of attachment 273153 [details] [review]:

Thanks. Please fix "the one" thing below and commit to master.

::: calendar/gui/e-cal-component-preview.c
@@ +231,3 @@
 	for (iter = list; iter != NULL; iter = iter->next) {
 		const gchar *category = iter->data;
+		gchar *icon_file;  /* owned */

Please do not write the /* owner */ comment, it's understood from the fact that the string variable is defined as non-const. Remove the comment from the whole set of changes.
Comment 3 Philip Withnall 2014-03-28 10:46:33 UTC
Pushed to master with the changes requested above. Thanks for the fast review!

Attachment 273153 [details] pushed as 61b4bac - e-util: Port to thread-safe ECategories API