After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727213 - W32: Notebook widget is not styled correctly
W32: Notebook widget is not styled correctly
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-03-28 06:25 UTC by LRN
Modified: 2014-04-04 10:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add MSW7 notebook theme, move old notebook theme into XP-only CSS (12.47 KB, patch)
2014-03-28 06:26 UTC, LRN
committed Details | Review
How it looks without the patch (6.56 KB, image/png)
2014-03-28 06:27 UTC, LRN
  Details
How it looks with the patch (7.43 KB, image/png)
2014-03-28 06:28 UTC, LRN
  Details

Description LRN 2014-03-28 06:25:50 UTC
The problem is that W32 only has "tabs above the notebook" style (and maybe
"tabs below the notebook", though i don't remember seeing it in use).
Drawing these W32 theme parts on tabs that are located on the left or on the
right side results in obvious, jarring ugliness.

Notebook is one of the worst widgets as far as W32-lookalike styling goes,
as GTK implementation mismatches W32 implementation in a number of ways
(which is why i gave up on making a classic theme for the notebook widget).
In the end i just looked at the way W32 styles notebook tabs and re-created
this with gradients and hardcoded colors. This looks sufficiently OK.

I left the previous (broken) style in XP-specific CSS file, since on XP
notebook tabs must look different, and i'm not about to make another such
style specifically for XP. So on XP tabs-on-top notebooks look OK and other
orientations are still broken.
If needed, MSW7 notebook style can be moved into gtk-win32-base.css after all,
which will apply it to XP too, trading off XP theme conformance for
non-brokenness.
Comment 1 LRN 2014-03-28 06:26:10 UTC
Created attachment 273139 [details] [review]
Add MSW7 notebook theme, move old notebook theme into XP-only CSS
Comment 2 LRN 2014-03-28 06:27:49 UTC
Created attachment 273140 [details]
How it looks without the patch
Comment 3 LRN 2014-03-28 06:28:28 UTC
Created attachment 273141 [details]
How it looks with the patch

Note the prelight on one of the tabs. The patch adds that too.
Comment 4 Matthias Clasen 2014-03-28 19:00:26 UTC
Review of attachment 273139 [details] [review]:

ok
Comment 5 LRN 2014-04-04 10:25:29 UTC
Attachment 273139 [details] pushed as c2b4891 - W32: Add MSW7 notebook theme, move old notebook theme into XP-only CSS